diff --git a/ISSUE_TEMPLATE.md b/ISSUE_TEMPLATE.md
new file mode 100644
index 000000000..d8ef17752
--- /dev/null
+++ b/ISSUE_TEMPLATE.md
@@ -0,0 +1,35 @@
+_Before creating an issue, please search the existing issues to see if a similar one has already been created. You can search issues by specific labels (e.g. `label:nearby `) or just by typing keywords into the search filter._
+
+**Summary:**
+
+Summarize your issue in one sentence (what goes wrong, what did you expect to happen)
+
+**Steps to reproduce:**
+
+How can we reproduce the issue?
+
+**Add System logs:**
+
+Add logcat files here (if possible).
+
+**Expected behavior:**
+
+What did you expect the App to do?
+
+**Observed behavior:**
+
+What did you see instead? Describe your issue in detail here.
+
+**Device and Android version:**
+
+What make and model device (e.g., Samsung J7) did you encounter this on? What Android
+version (e.g., Android 4.0 Ice Cream Sandwich or Android 6.0 Marshmallow) are you running? Is it
+ the stock version from the manufacturer or a custom ROM ?
+
+ **Commons app version:**
+
+You can find this information by going to the navigation drawer in the app and tapping 'About'
+
+**Screen-shots:**
+
+Can be created by pressing the Volume Down and Power Button at the same time on Android 4.0 and higher.
diff --git a/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java b/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java
index a6cf2d65d..ab156bab7 100644
--- a/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java
+++ b/app/src/main/java/fr/free/nrw/commons/CommonsApplication.java
@@ -57,7 +57,6 @@ public class CommonsApplication extends Application {
public static final String FEEDBACK_EMAIL_SUBJECT = "Commons Android App (%s) Feedback";
- private CommonsApplicationComponent component;
private RefWatcher refWatcher;
@@ -136,9 +135,10 @@ public class CommonsApplication extends Application {
.subscribe(() -> {
Timber.d("All accounts have been removed");
//TODO: fix preference manager
- defaultPrefs.edit().clear().commit();
- applicationPrefs.edit().clear().commit();
- applicationPrefs.edit().putBoolean("firstrun", false).apply();otherPrefs.edit().clear().commit();
+ defaultPrefs.edit().clear().apply();
+ applicationPrefs.edit().clear().apply();
+ applicationPrefs.edit().putBoolean("firstrun", false).apply();
+ otherPrefs.edit().clear().apply();
updateAllDatabases();
logoutListener.onLogoutComplete();
diff --git a/app/src/main/java/fr/free/nrw/commons/category/CategorizationFragment.java b/app/src/main/java/fr/free/nrw/commons/category/CategorizationFragment.java
index 76a70c0b3..51376c7fe 100644
--- a/app/src/main/java/fr/free/nrw/commons/category/CategorizationFragment.java
+++ b/app/src/main/java/fr/free/nrw/commons/category/CategorizationFragment.java
@@ -298,8 +298,10 @@ public class CategorizationFragment extends CommonsDaggerSupportFragment {
//Check if item contains a 4-digit word anywhere within the string (.* is wildcard)
//And that item does not equal the current year or previous year
//And if it is an irrelevant category such as Media_needing_categories_as_of_16_June_2017(Issue #750)
+ //Check if the year in the form of XX(X)0s is relevant, i.e. in the 2000s or 2010s as stated in Issue #1029
return ((item.matches(".*(19|20)\\d{2}.*") && !item.contains(yearInString) && !item.contains(prevYearInString))
- || item.matches("(.*)needing(.*)") || item.matches("(.*)taken on(.*)"));
+ || item.matches("(.*)needing(.*)") || item.matches("(.*)taken on(.*)")
+ || (item.matches(".*0s.*") && !item.matches(".*(200|201)0s.*")));
}
private void updateCategoryCount(CategoryItem item) {
diff --git a/app/src/main/java/fr/free/nrw/commons/location/LatLng.java b/app/src/main/java/fr/free/nrw/commons/location/LatLng.java
index a9848f27d..494cce077 100644
--- a/app/src/main/java/fr/free/nrw/commons/location/LatLng.java
+++ b/app/src/main/java/fr/free/nrw/commons/location/LatLng.java
@@ -38,7 +38,7 @@ public class LatLng {
/**
* gets the latitude and longitude of a given non-null location
* @param location the non-null location of the user
- * @return A new instance of the class
+ * @return LatLng the Latitude and Longitude of a given location
*/
public static LatLng from(@NonNull Location location) {
return new LatLng(location.getLatitude(), location.getLongitude(), location.getAccuracy());
@@ -48,13 +48,12 @@ public class LatLng {
* creates a hash code for the longitude and longitude
*/
public int hashCode() {
- boolean var1 = true;
- byte var2 = 1;
- long var3 = Double.doubleToLongBits(this.latitude);
- int var5 = 31 * var2 + (int)(var3 ^ var3 >>> 32);
- var3 = Double.doubleToLongBits(this.longitude);
- var5 = 31 * var5 + (int)(var3 ^ var3 >>> 32);
- return var5;
+ byte var1 = 1;
+ long var2 = Double.doubleToLongBits(this.latitude);
+ int var3 = 31 * var1 + (int)(var2 ^ var2 >>> 32);
+ var2 = Double.doubleToLongBits(this.longitude);
+ var3 = 31 * var3 + (int)(var2 ^ var2 >>> 32);
+ return var3;
}
/**
diff --git a/app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.java b/app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.java
index 2a017c854..7dfba7a64 100644
--- a/app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.java
+++ b/app/src/main/java/fr/free/nrw/commons/settings/SettingsFragment.java
@@ -71,7 +71,12 @@ public class SettingsFragment extends PreferenceFragment {
uploadLimit.setText(uploads + "");
uploadLimit.setSummary(uploads + "");
uploadLimit.setOnPreferenceChangeListener((preference, newValue) -> {
- int value = Integer.parseInt(newValue.toString());
+ int value;
+ try {
+ value = Integer.parseInt(newValue.toString());
+ } catch(Exception e) {
+ value = 100; //Default number
+ }
final SharedPreferences.Editor editor = prefs.edit();
if (value > 500) {
new AlertDialog.Builder(getActivity())
@@ -85,9 +90,9 @@ public class SettingsFragment extends PreferenceFragment {
uploadLimit.setSummary(500 + "");
uploadLimit.setText(500 + "");
} else {
- editor.putInt(Prefs.UPLOADS_SHOWING, Integer.parseInt(newValue.toString()));
+ editor.putInt(Prefs.UPLOADS_SHOWING, value);
editor.putBoolean(Prefs.IS_CONTRIBUTION_COUNT_CHANGED,true);
- uploadLimit.setSummary(newValue.toString());
+ uploadLimit.setSummary(String.valueOf(value));
}
editor.apply();
return true;
diff --git a/app/src/main/java/fr/free/nrw/commons/upload/FileUtils.java b/app/src/main/java/fr/free/nrw/commons/upload/FileUtils.java
index 2cf18e7d7..0026a6ce0 100644
--- a/app/src/main/java/fr/free/nrw/commons/upload/FileUtils.java
+++ b/app/src/main/java/fr/free/nrw/commons/upload/FileUtils.java
@@ -49,18 +49,14 @@ public class FileUtils {
if ("primary".equalsIgnoreCase(type)) {
return Environment.getExternalStorageDirectory() + "/" + split[1];
}
- }
- // DownloadsProvider
- else if (isDownloadsDocument(uri)) {
+ } else if (isDownloadsDocument(uri)) { // DownloadsProvider
final String id = DocumentsContract.getDocumentId(uri);
final Uri contentUri = ContentUris.withAppendedId(
Uri.parse("content://downloads/public_downloads"), Long.valueOf(id));
return getDataColumn(context, contentUri, null, null);
- }
- // MediaProvider
- else if (isMediaDocument(uri)) {
+ } else if (isMediaDocument(uri)) { // MediaProvider
final String docId = DocumentsContract.getDocumentId(uri);
final String[] split = docId.split(":");
final String type = split[0];
diff --git a/app/src/main/java/fr/free/nrw/commons/utils/ExecutorUtils.java b/app/src/main/java/fr/free/nrw/commons/utils/ExecutorUtils.java
index 15f18ee5e..57ed86eeb 100644
--- a/app/src/main/java/fr/free/nrw/commons/utils/ExecutorUtils.java
+++ b/app/src/main/java/fr/free/nrw/commons/utils/ExecutorUtils.java
@@ -15,6 +15,8 @@ public class ExecutorUtils {
}
};
- public static Executor uiExecutor() { return uiExecutor; }
+ public static Executor uiExecutor() {
+ return uiExecutor;
+ }
}
diff --git a/app/src/main/res/layout/activity_contributions.xml b/app/src/main/res/layout/activity_contributions.xml
index 9065618f2..51a48f0a5 100644
--- a/app/src/main/res/layout/activity_contributions.xml
+++ b/app/src/main/res/layout/activity_contributions.xml
@@ -15,9 +15,7 @@
android:layout_width="match_parent"
android:layout_height="wrap_content" />
-
- দয়া করে আপলোড করবেন না:
u2022 আপনার বন্ধুর সেলফি বা ছবি \nu2022 ইন্টারনেট থেকে ডাউনলোড করা ছবি \nu2022 মালিকানাযুক্ত অ্যাপসমূহের স্ক্রীনশট
আপলোডের উদাহরণ:
- u2022 শিরোনাম: সিডনি অপেরা হাউস \nu2022 বিবরণ: উপসাগর থেকে দেখা সিডনি অপেরা হাউস\nu2022 বিষয়শ্রেণী: সিডনি অপেরা হাউস, পশ্চিম দিক থেকে সিডনি অপেরা হাউস, সিডনি অপেরা হাউসের দূরবর্তী দৃশ্য
+ - শিরোনাম: সিডনি অপেরা হাউস \n- বিবরণ: উপসাগর থেকে দেখা সিডনি অপেরা হাউস\n- বিষয়শ্রেণী: সিডনি অপেরা হাউস, পশ্চিম দিক থেকে সিডনি অপেরা হাউস, সিডনি অপেরা হাউসের দূরবর্তী দৃশ্য
আপনার ছবি দিয়ে অবদান রাখুন। উইকিপিডিয়ার নিবন্ধগুলিকে নতুন রূপ দিতে সাহায্য করুন!
উইকিপিডিয়াতে চিত্র উইকিমিডিয়া কমন্স থেকে এসেছে।
আপনার ছবি সারা বিশ্বের শিক্ষিত মানুষকে সাহায্য করবে।
@@ -191,6 +191,7 @@
প্রতিক্রিয়া
প্রস্থান
ভূমিকা
+ বিজ্ঞপ্তি
অবস্থানের অনুমতি ছাড়া কাছাকাছি জায়গাগুলি প্রদর্শন করা যাবে না
কোন বিবরণ পাওয়া যায়নি
কমন্সে ফাইলের পাতা
diff --git a/app/src/main/res/values-cs/strings.xml b/app/src/main/res/values-cs/strings.xml
index 39c5af4cf..77fdac33c 100644
--- a/app/src/main/res/values-cs/strings.xml
+++ b/app/src/main/res/values-cs/strings.xml
@@ -55,7 +55,7 @@
Spustit GPS
Žádné nahrané soubory
- - Žádné soubory
+ - \@string/contributions_subtitle_zero
- 1 soubor
- %1$d souborů
diff --git a/app/src/main/res/values-ko-kp/strings.xml b/app/src/main/res/values-ko-rKP/strings.xml
similarity index 100%
rename from app/src/main/res/values-ko-kp/strings.xml
rename to app/src/main/res/values-ko-rKP/strings.xml
diff --git a/app/src/main/res/values-kum/error.xml b/app/src/main/res/values-kum/error.xml
new file mode 100644
index 000000000..706bdae51
--- /dev/null
+++ b/app/src/main/res/values-kum/error.xml
@@ -0,0 +1,6 @@
+
+
+ Вагь. Бир зат чы терс гетди!
+ Этгенигизни язып бизге электрон почгъа йибери. О масъаланы чечме кёмек этежек!
+ Савбол!
+
diff --git a/app/src/main/res/values-ne/strings.xml b/app/src/main/res/values-ne/strings.xml
index f2cab024b..10be9f8f8 100644
--- a/app/src/main/res/values-ne/strings.xml
+++ b/app/src/main/res/values-ne/strings.xml
@@ -90,4 +90,5 @@
वर्णन छैन
अज्ञान अनुमतिपत्र
ताजागर्ने
+ टगल दृश्य
diff --git a/app/src/main/res/values-th/strings.xml b/app/src/main/res/values-th/strings.xml
index 2b3c68a2d..21eeb12f1 100644
--- a/app/src/main/res/values-th/strings.xml
+++ b/app/src/main/res/values-th/strings.xml
@@ -52,7 +52,10 @@
เปิดใช้งาน GPS
ยังไม่มีการอัปโหลด
การอัปโหลด %1$d รายการ
- กำลังเริ่มการอัปโหลด %1$d รายการ
+
+ - กำลังเริ่มอัปโหลด %1$d รายการ
+ - กำลังเริ่มอัปโหลด %1$d รายการ
+
- การอัปโหลด %1$d รายการ
- การอัปโหลด %1$d รายการ