From 349b8ef48232612970f6058b28f9d6d9f442426a Mon Sep 17 00:00:00 2001 From: Rohit Verma Date: Sat, 24 Aug 2024 20:49:08 +0530 Subject: [PATCH] refactor: permission should not be check on onCreate for some cases --- .../commons/contributions/MainActivity.java | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java b/app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java index 63bde1be9..58e064552 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/MainActivity.java @@ -162,14 +162,17 @@ public class MainActivity extends BaseActivity * so that location in the EXIF metadata of the images shared by the user * is retained on devices running Android 10 or above */ - if (VERSION.SDK_INT >= VERSION_CODES.Q) { - PermissionUtils.checkPermissionsAndPerformAction( - this, - () -> {}, - R.string.media_location_permission_denied, - R.string.add_location_manually, - permission.ACCESS_MEDIA_LOCATION); - } +// if (VERSION.SDK_INT >= VERSION_CODES.Q) { +// ActivityCompat.requestPermissions(this, +// new String[]{Manifest.permission.ACCESS_MEDIA_LOCATION}, 0); +// PermissionUtils.checkPermissionsAndPerformAction( +// this, +// () -> {}, +// R.string.media_location_permission_denied, +// R.string.add_location_manually, +// permission.ACCESS_MEDIA_LOCATION); +// } + checkAndResumeStuckUploads(); } }