Issue-5662-kotlinstyle (#5833)

* *.kt: bulk correction of formatting using ktlint --format

* *.kt: replace wildcard imports and second stage auto format ktlint --format

* QuizQuestionTest.kt: modified property names to camel case to meet ktlint standard

* LevelControllerTest.kt: modified property names to camel case to meet ktlint standard

* QuizActivityUnitTest.kt: modified property names to camel case to meet ktlint standard

* MediaDetailFragmentUnitTests.kt: modified property names to camel case to meet ktlint standard

* UploadWorker.kt: modified property names to camel case to meet ktlint standard

* UploadClient.kt: modified property names to camel case to meet ktlint standard

* BasePagingPresenter.kt: modified property names to camel case to meet ktlint standard

* DescriptionEditActivity.kt: modified property names to camel case to meet ktlint standard

* OnSwipeTouchListener.kt: modified property names to camel case to meet ktlint standard

* MediaDetailFragmentUnitTests.kt: corrected excessive line length to meet ktlint standard

* DepictedItem.kt: corrected property name format and catch format to for  ktlint standard

* UploadCategoryAdapter.kt: corrected class definition format to meet ktlint standard

* CustomSelectorActivity.kt: reformatted function names to first letter lowercase to meet ktlint standard

* MediaDetailFragmentUnitTests.kt: fix string literal indentation to meet ktlint standard

* NotForUploadDao.kt: file renamed to match class name, new file NotForUploadStatusDao.kt

* UploadedDao.kt: file renamed to match class name, new file UploadedStatusDao.kt

* Urls.kt: fixed excessive line length for ktLint standard

* Snak_partial.kt & Statement_partial.kt: refactored to remove underscores in class names to meet ktLint standard

* *.kt: fixed consecutive KDOC error for ktLint

* PageableBaseDataSourceTest.kt & UploadPresenterTest.kt: fixed excessive line lengths to meet ktLint standard

* CheckboxTriStatesTest.kt: renamed file to match class name to meet ktLint standard

* .kt: resolved backing-property-naming error in ktLint, made matching properties public, matched names and refactored

* TestConnectionFactory.kt: fixed property naming to adhere to ktLint standard
This commit is contained in:
tristan 2024-09-19 14:56:45 +10:00 committed by GitHub
parent 950539c55c
commit 2d82a430c4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
405 changed files with 11032 additions and 9137 deletions

View file

@ -10,7 +10,6 @@ import android.os.Looper
import android.view.LayoutInflater
import android.view.View
import androidx.recyclerview.widget.RecyclerView
import androidx.test.core.app.ApplicationProvider
import fr.free.nrw.commons.Media
import fr.free.nrw.commons.R
import fr.free.nrw.commons.TestCommonsApplication
@ -26,7 +25,6 @@ import org.junit.Before
import org.junit.Test
import org.junit.runner.RunWith
import org.mockito.Mock
import org.mockito.Mockito.verify
import org.mockito.Mockito.`when`
import org.mockito.MockitoAnnotations
import org.powermock.reflect.Whitebox
@ -39,13 +37,12 @@ import org.robolectric.annotation.LooperMode
import org.robolectric.shadows.ShadowAlertDialog
import org.robolectric.shadows.ShadowProgressDialog
import java.lang.reflect.Method
import java.util.*
import java.util.Date
@RunWith(RobolectricTestRunner::class)
@Config(sdk = [21], application = TestCommonsApplication::class)
@LooperMode(LooperMode.Mode.PAUSED)
class DescriptionEditActivityUnitTest {
private lateinit var context: Context
private lateinit var activity: Activity
private lateinit var uploadMediaDetails: ArrayList<UploadMediaDetail>
@ -64,10 +61,19 @@ class DescriptionEditActivityUnitTest {
fun setUp() {
MockitoAnnotations.initMocks(this)
context = RuntimeEnvironment.getApplication().applicationContext
uploadMediaDetails = mutableListOf(UploadMediaDetail("en", "desc"))
uploadMediaDetails =
mutableListOf(UploadMediaDetail("en", "desc"))
as ArrayList<UploadMediaDetail>
media = Media("filename", "creator", "url", "thumburl",
"localpath", Date(197000), "extmetadata")
media =
Media(
"filename",
"creator",
"url",
"thumburl",
"localpath",
Date(197000),
"extmetadata",
)
val intent = Intent().putExtra("title", "read")
val bundle = Bundle()
@ -87,7 +93,7 @@ class DescriptionEditActivityUnitTest {
Whitebox.setInternalState(activity, "binding", binding)
Whitebox.setInternalState(activity, "savedLanguageValue", "bn")
Whitebox.setInternalState(activity, "media", media)
Whitebox.setInternalState(activity,"descriptionAndCaptions",uploadMediaDetails)
Whitebox.setInternalState(activity, "descriptionAndCaptions", uploadMediaDetails)
`when`(uploadMediaDetailAdapter.items).thenReturn(uploadMediaDetails)
}
@ -101,9 +107,10 @@ class DescriptionEditActivityUnitTest {
@Throws(Exception::class)
fun testShowLoggingProgressBar() {
Shadows.shadowOf(Looper.getMainLooper()).idle()
val method: Method = DescriptionEditActivity::class.java.getDeclaredMethod(
"showLoggingProgressBar"
)
val method: Method =
DescriptionEditActivity::class.java.getDeclaredMethod(
"showLoggingProgressBar",
)
method.isAccessible = true
method.invoke(activity)
val dialog: ProgressDialog = ShadowProgressDialog.getLatestDialog() as ProgressDialog
@ -114,9 +121,11 @@ class DescriptionEditActivityUnitTest {
@Throws(Exception::class)
fun testUpdateDescription() {
Shadows.shadowOf(Looper.getMainLooper()).idle()
val method: Method = DescriptionEditActivity::class.java.getDeclaredMethod(
"updateDescription", List::class.java
)
val method: Method =
DescriptionEditActivity::class.java.getDeclaredMethod(
"updateDescription",
List::class.java,
)
method.isAccessible = true
method.invoke(activity, mutableListOf(UploadMediaDetail("en", "desc")))
assertEquals(activity.isFinishing, true)
@ -126,9 +135,11 @@ class DescriptionEditActivityUnitTest {
@Throws(Exception::class)
fun testOnSubmitButtonClicked() {
Shadows.shadowOf(Looper.getMainLooper()).idle()
val method: Method = DescriptionEditActivity::class.java.getDeclaredMethod(
"onSubmitButtonClicked", View::class.java
)
val method: Method =
DescriptionEditActivity::class.java.getDeclaredMethod(
"onSubmitButtonClicked",
View::class.java,
)
method.isAccessible = true
method.invoke(activity, null)
assertEquals(activity.isFinishing, true)
@ -138,9 +149,11 @@ class DescriptionEditActivityUnitTest {
@Throws(Exception::class)
fun testOnBackButtonClicked() {
Shadows.shadowOf(Looper.getMainLooper()).idle()
val method: Method = DescriptionEditActivity::class.java.getDeclaredMethod(
"onBackButtonClicked", View::class.java
)
val method: Method =
DescriptionEditActivity::class.java.getDeclaredMethod(
"onBackButtonClicked",
View::class.java,
)
method.isAccessible = true
method.invoke(activity, null)
assertEquals(activity.isFinishing, true)
@ -150,9 +163,11 @@ class DescriptionEditActivityUnitTest {
@Throws(Exception::class)
fun testOnPrimaryCaptionTextChange() {
Shadows.shadowOf(Looper.getMainLooper()).idle()
val method: Method = DescriptionEditActivity::class.java.getDeclaredMethod(
"onPrimaryCaptionTextChange", Boolean::class.java
)
val method: Method =
DescriptionEditActivity::class.java.getDeclaredMethod(
"onPrimaryCaptionTextChange",
Boolean::class.java,
)
method.isAccessible = true
method.invoke(activity, true)
}
@ -161,17 +176,19 @@ class DescriptionEditActivityUnitTest {
@Throws(Exception::class)
fun testShowInfoAlert() {
Shadows.shadowOf(Looper.getMainLooper()).idle()
val method: Method = DescriptionEditActivity::class.java.getDeclaredMethod(
"showInfoAlert", Int::class.java, Int::class.java
)
val method: Method =
DescriptionEditActivity::class.java.getDeclaredMethod(
"showInfoAlert",
Int::class.java,
Int::class.java,
)
method.isAccessible = true
method.invoke(
activity,
android.R.string.ok,
android.R.string.ok
android.R.string.ok,
)
val dialog: AlertDialog = ShadowAlertDialog.getLatestDialog() as AlertDialog
assertEquals(dialog.isShowing, true)
}
}

View file

@ -10,12 +10,13 @@ import org.junit.Test
import org.junit.jupiter.api.Assertions.assertEquals
import org.mockito.ArgumentMatchers.anyString
import org.mockito.Mock
import org.mockito.Mockito.*
import org.mockito.Mockito.times
import org.mockito.Mockito.verify
import org.mockito.Mockito.`when`
import org.mockito.MockitoAnnotations
import java.lang.reflect.Method
class DescriptionEditHelperUnitTest {
private lateinit var helper: DescriptionEditHelper
@Mock
@ -43,8 +44,8 @@ class DescriptionEditHelperUnitTest {
pageEditClient.edit(
anyString(),
anyString(),
anyString()
)
anyString(),
),
).thenReturn(Observable.just(true))
helper.addDescription(context, media, "test")
verify(pageEditClient, times(1)).edit(anyString(), anyString(), anyString())
@ -58,56 +59,67 @@ class DescriptionEditHelperUnitTest {
anyString(),
anyString(),
anyString(),
anyString()
)
anyString(),
),
).thenReturn(Observable.just(0))
helper.addCaption(context, media, "test", "test")
verify(pageEditClient, times(1)).setCaptions(
anyString(),
anyString(),
anyString(),
anyString()
anyString(),
)
}
@Test
fun testShowCaptionEditNotificationCaseFalse() {
val method: Method = DescriptionEditHelper::class.java.getDeclaredMethod(
"showCaptionEditNotification", Context::class.java, Media::class.java,
Int::class.java
)
val method: Method =
DescriptionEditHelper::class.java.getDeclaredMethod(
"showCaptionEditNotification",
Context::class.java,
Media::class.java,
Int::class.java,
)
method.isAccessible = true
assertEquals(method.invoke(helper, context, media, 0), false)
}
@Test
fun testShowCaptionEditNotificationCaseTrue() {
val method: Method = DescriptionEditHelper::class.java.getDeclaredMethod(
"showCaptionEditNotification", Context::class.java, Media::class.java,
Int::class.java
)
val method: Method =
DescriptionEditHelper::class.java.getDeclaredMethod(
"showCaptionEditNotification",
Context::class.java,
Media::class.java,
Int::class.java,
)
method.isAccessible = true
assertEquals(method.invoke(helper, context, media, 1), true)
}
@Test
fun testShowDescriptionEditNotificationCaseFalse() {
val method: Method = DescriptionEditHelper::class.java.getDeclaredMethod(
"showDescriptionEditNotification", Context::class.java, Media::class.java,
Boolean::class.java
)
val method: Method =
DescriptionEditHelper::class.java.getDeclaredMethod(
"showDescriptionEditNotification",
Context::class.java,
Media::class.java,
Boolean::class.java,
)
method.isAccessible = true
assertEquals(method.invoke(helper, context, media, false), false)
}
@Test
fun testShowDescriptionEditNotificationCaseTrue() {
val method: Method = DescriptionEditHelper::class.java.getDeclaredMethod(
"showDescriptionEditNotification", Context::class.java, Media::class.java,
Boolean::class.java
)
val method: Method =
DescriptionEditHelper::class.java.getDeclaredMethod(
"showDescriptionEditNotification",
Context::class.java,
Media::class.java,
Boolean::class.java,
)
method.isAccessible = true
assertEquals(method.invoke(helper, context, media, true), true)
}
}
}