Code style

app/src/main/java/fr/free/nrw/commons/location/LatLng.java

@@ -2,8 +2,8 @@ package fr.free.nrw.commons.location;
 
 public class LatLng {
 
-    public final double latitude;
+    private final double latitude;
-    public final double longitude;
+    private final double longitude;
     private final float accuracy;
 
     /** Accepts latitude and longitude.
@@ -95,4 +95,31 @@ public class LatLng {
         return formatCoordinate(this.latitude) + " " + this.getNorthSouth() + ", "
                + formatCoordinate(this.longitude) + " " + this.getEastWest();
     }
+
+    /**
+     * Return the location accuracy in meter.
+     *
+     * @return float
+     */
+    public float getAccuracy() {
+        return accuracy;
+    }
+
+    /**
+     * Return the longitude in degrees.
+     *
+     * @return double
+     */
+    public double getLongitude() {
+        return longitude;
+    }
+
+    /**
+     * Return the latitude in degrees.
+     *
+     * @return double
+     */
+    public double getLatitude() {
+        return latitude;
+    }
 }

app/src/main/java/fr/free/nrw/commons/nearby/NearbyController.java

@@ -109,8 +109,8 @@ public class NearbyController {
             nearbyBaseMarker.title(place.name);
             nearbyBaseMarker.position(
                     new com.mapbox.mapboxsdk.geometry.LatLng(
-                            place.location.latitude,
+                            place.location.getLatitude(),
-                            place.location.longitude));
+                            place.location.getLongitude()));
             nearbyBaseMarker.place(place);
             nearbyBaseMarker.icon(icon);
 

app/src/main/java/fr/free/nrw/commons/nearby/NearbyInfoDialog.java

@@ -122,8 +122,8 @@ public class NearbyInfoDialog extends OverlayDialog {
         Bundle bundle = new Bundle();
         bundle.putString(ARG_TITLE, place.name);
         bundle.putString(ARG_DESC, place.description);
-        bundle.putDouble(ARG_LATITUDE, place.location.latitude);
+        bundle.putDouble(ARG_LATITUDE, place.location.getLatitude());
-        bundle.putDouble(ARG_LONGITUDE, place.location.longitude);
+        bundle.putDouble(ARG_LONGITUDE, place.location.getLongitude());
         bundle.putParcelable(ARG_SITE_LINK, place.siteLinks);
         mDialog.setArguments(bundle);
         DialogUtil.showSafely(fragmentActivity, mDialog);
@@ -138,7 +138,8 @@ public class NearbyInfoDialog extends OverlayDialog {
     @OnClick(R.id.link_preview_directions_button)
     void onDirectionsClick() {
         //Open map app at given position
-        Uri gmmIntentUri = Uri.parse("geo:0,0?q=" + location.latitude + "," + location.longitude);
+        Uri gmmIntentUri = Uri.parse(
+                "geo:0,0?q=" + location.getLatitude() + "," + location.getLongitude());
         Intent mapIntent = new Intent(Intent.ACTION_VIEW, gmmIntentUri);
 
         if (mapIntent.resolveActivity(getActivity().getPackageManager()) != null) {

app/src/main/java/fr/free/nrw/commons/nearby/NearbyListFragment.java

@@ -85,8 +85,8 @@ public class NearbyListFragment extends ListFragment  {
         Place place = (Place) listview.getItemAtPosition(position);
         LatLng placeLatLng = place.location;
 
-        double latitude = placeLatLng.latitude;
+        double latitude = placeLatLng.getLatitude();
-        double longitude = placeLatLng.longitude;
+        double longitude = placeLatLng.getLongitude();
 
         Timber.d("Item at position %d has coords: Lat: %f Long: %f", position, latitude, longitude);
 

app/src/main/java/fr/free/nrw/commons/nearby/NearbyMapFragment.java

@@ -83,7 +83,7 @@ public class NearbyMapFragment extends android.support.v4.app.Fragment {
         MapboxMapOptions options = new MapboxMapOptions()
                 .styleUrl(Style.OUTDOORS)
                 .camera(new CameraPosition.Builder()
-                        .target(new LatLng(curLatLng.latitude, curLatLng.longitude))
+                        .target(new LatLng(curLatLng.getLatitude(), curLatLng.getLongitude()))
                         .zoom(11)
                         .build());
 
@@ -125,11 +125,11 @@ public class NearbyMapFragment extends android.support.v4.app.Fragment {
      */
     public void addCurrentLocationMarker(MapboxMap mapboxMap) {
         MarkerOptions currentLocationMarker = new MarkerOptions()
-                .position(new LatLng(curLatLng.latitude, curLatLng.longitude));
+                .position(new LatLng(curLatLng.getLatitude(), curLatLng.getLongitude()));
         mapboxMap.addMarker(currentLocationMarker);
 
-        List<LatLng> circle = createCircleArray(curLatLng.latitude, curLatLng.longitude,
+        List<LatLng> circle = createCircleArray(curLatLng.getLatitude(), curLatLng.getLongitude(),
-                curLatLng.accuracy * 2, 100);
+                curLatLng.getAccuracy() * 2, 100);
 
         mapboxMap.addPolygon(
                 new PolygonOptions()

app/src/main/java/fr/free/nrw/commons/nearby/NearbyPlaces.java

@@ -74,8 +74,8 @@ public class NearbyPlaces {
 
         String query = wikidataQuery
                 .replace("${RAD}", String.format(Locale.ROOT, "%.2f", radius))
-                .replace("${LAT}", String.format(Locale.ROOT, "%.4f", cur.latitude))
+                .replace("${LAT}", String.format(Locale.ROOT, "%.4f", cur.getLatitude()))
-                .replace("${LONG}", String.format(Locale.ROOT, "%.4f", cur.longitude))
+                .replace("${LONG}", String.format(Locale.ROOT, "%.4f", cur.getLongitude()))
                 .replace("${LANG}", lang);
 
         Timber.v("# Wikidata query: \n" + query);

app/src/main/java/fr/free/nrw/commons/utils/LengthUtils.java

@@ -38,10 +38,10 @@ public class LengthUtils {
     }
 
     private static double computeAngleBetween(LatLng from, LatLng to) {
-        return distanceRadians(Math.toRadians(from.latitude),
+        return distanceRadians(Math.toRadians(from.getLatitude()),
-                Math.toRadians(from.longitude),
+                Math.toRadians(from.getLongitude()),
-                Math.toRadians(to.latitude),
+                Math.toRadians(to.getLatitude()),
-                Math.toRadians(to.longitude));
+                Math.toRadians(to.getLongitude()));
     }
 
     private static double distanceRadians(double lat1, double lng1, double lat2, double lng2) {