diff --git a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java index e4d16cf39..d7b192c07 100644 --- a/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java +++ b/app/src/main/java/fr/free/nrw/commons/contributions/ContributionsFragment.java @@ -615,10 +615,11 @@ public class ContributionsFragment Place closestNearbyPlace = nearbyPlacesInfo.placeList.get(0); String distance = formatDistanceBetween(curLatLng, closestNearbyPlace.location); closestNearbyPlace.setDistance(distance); - nearbyNotificationCardView.updateContent (true, closestNearbyPlace); + nearbyNotificationCardView.updateContent(closestNearbyPlace); + nearbyNotificationCardView.setVisibility(View.VISIBLE); } else { // Means that no close nearby place is found - nearbyNotificationCardView.updateContent (false, null); + nearbyNotificationCardView.setVisibility(View.GONE); } } diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyNotificationCardView.java b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyNotificationCardView.java index 1b43bdf35..4dbdb6c0e 100644 --- a/app/src/main/java/fr/free/nrw/commons/nearby/NearbyNotificationCardView.java +++ b/app/src/main/java/fr/free/nrw/commons/nearby/NearbyNotificationCardView.java @@ -116,10 +116,9 @@ public class NearbyNotificationCardView extends SwipableCardView { /** * Pass place information to views. - * @param isClosestNearbyPlaceFound false if there are no close place * @param place Closes place where we will get information from */ - public void updateContent(boolean isClosestNearbyPlaceFound, Place place) { + public void updateContent(Place place) { Timber.d("Update nearby card notification content"); this.setVisibility(VISIBLE); cardViewVisibilityState = CardViewVisibilityState.READY; @@ -131,14 +130,9 @@ public class NearbyNotificationCardView extends SwipableCardView { notificationTitle.setVisibility(VISIBLE); notificationDistance.setVisibility(VISIBLE); notificationIcon.setVisibility(VISIBLE); + notificationTitle.setText(place.name); + notificationDistance.setText(place.distance); - if (isClosestNearbyPlaceFound) { - notificationTitle.setText(place.name); - notificationDistance.setText(place.distance); - } else { - notificationDistance.setText(""); - notificationTitle.setText(R.string.no_close_nearby); - } } @Override