mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 21:03:54 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Null checks to avoid NPEs (#1917) (#1918)

Browse source
This commit is contained in:
Henrique Guedes 2018-10-31 05:25:49 -04:00 • committed by Josephine Lim
parent 154f1622b2
commit 293cccd897
3 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

3
app/src/main/java/fr/free/nrw/commons/category/CategoryImagesListFragment.java
View file

@ -263,6 +263,9 @@ public class CategoryImagesListFragment extends DaggerFragment {
* @return GridView Adapter * @return GridView Adapter
*/ */
public ListAdapter getAdapter() { public ListAdapter getAdapter() {
if(gridView == null) {
return null;
}
return gridView.getAdapter(); return gridView.getAdapter();
} }

4
app/src/main/java/fr/free/nrw/commons/explore/images/SearchImageFragment.java
View file

@ -125,7 +125,9 @@ public class SearchImageFragment extends CommonsDaggerSupportFragment {
*/ */
public void updateImageList(String query) { public void updateImageList(String query) {
this.query = query; this.query = query;
imagesNotFoundView.setVisibility(GONE); if(imagesNotFoundView != null) {
imagesNotFoundView.setVisibility(GONE);
}
if(!NetworkUtils.isInternetConnectionEstablished(getContext())) { if(!NetworkUtils.isInternetConnectionEstablished(getContext())) {
handleNoInternet(); handleNoInternet();
return; return;

8
app/src/main/java/fr/free/nrw/commons/utils/FileUtils.java
View file

@ -45,8 +45,12 @@ public class FileUtils {
e.printStackTrace(); e.printStackTrace();
} finally { } finally {
try { try {
out.close(); if(out != null) {
in.close(); out.close();
}
if(in != null) {
in.close();
}
} catch (IOException e) { } catch (IOException e) {
e.printStackTrace(); e.printStackTrace();
} }