From 29269f10a4d7ab47ae9de6b19d9cb33a9fbacdeb Mon Sep 17 00:00:00 2001 From: misaochan Date: Mon, 8 Feb 2016 16:10:00 +1300 Subject: [PATCH] Moved bulk of code to onResume() Otherwise getCoords method is called in onCreate before locationlistener can be registered in onResume --- .../nrw/commons/upload/ShareActivity.java | 22 ++++++++++--------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/commons/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java b/commons/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java index 82c5889eb..8c5e205db 100644 --- a/commons/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java +++ b/commons/src/main/java/fr/free/nrw/commons/upload/ShareActivity.java @@ -189,6 +189,17 @@ public class ShareActivity mediaUriString = mediaUri.toString(); ImageLoader.getInstance().displayImage(mediaUriString, backgroundImageView); + + if(savedInstanceState != null) { + contribution = savedInstanceState.getParcelable("contribution"); + } + requestAuthToken(); + } + + @Override + public void onResume() { + super.onResume(); + Log.d(TAG, "Uri: " + mediaUriString); Log.d(TAG, "Ext storage dir: " + Environment.getExternalStorageDirectory()); @@ -198,6 +209,7 @@ public class ShareActivity Log.d(TAG, "Calling GPSExtractor"); imageObj = new GPSExtractor(filePath, this); + imageObj.registerLocationManager(); if (filePath != null && !filePath.equals("")) { //Gets image coords if exist, otherwise gets last known coords @@ -232,16 +244,6 @@ public class ShareActivity } } - if(savedInstanceState != null) { - contribution = savedInstanceState.getParcelable("contribution"); - } - requestAuthToken(); - } - - @Override - public void onResume() { - super.onResume(); - imageObj.registerLocationManager(); } @Override