From 24a85a16a3ea6b1538c9b25a1ff4d0fc78c28d05 Mon Sep 17 00:00:00 2001 From: neslihanturan Date: Sun, 12 May 2019 10:32:09 +0300 Subject: [PATCH] Add javadocs and specific interfaces for list --- .../commons/nearby/mvp/NearbyContract.java | 4 +++- .../nearby/mvp/NearbyListContract.java | 19 +++++++++++++++++++ .../commons/nearby/mvp/NearbyMapContract.java | 9 ++++++++- 3 files changed, 30 insertions(+), 2 deletions(-) create mode 100644 app/src/main/java/fr/free/nrw/commons/nearby/mvp/NearbyListContract.java diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/mvp/NearbyContract.java b/app/src/main/java/fr/free/nrw/commons/nearby/mvp/NearbyContract.java index 6aa2eda24..0c69a7e7d 100644 --- a/app/src/main/java/fr/free/nrw/commons/nearby/mvp/NearbyContract.java +++ b/app/src/main/java/fr/free/nrw/commons/nearby/mvp/NearbyContract.java @@ -1,6 +1,7 @@ package fr.free.nrw.commons.nearby.mvp; public interface NearbyContract { + interface View { void showPlaces(); } @@ -10,7 +11,8 @@ public interface NearbyContract { void uploadImageCamera(); void bookmarkItem(); void getDirections(); - void openWikidata(); + void seeWikidataItem(); + void seeWikipediaArticle(); void rotateScreen(); } } diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/mvp/NearbyListContract.java b/app/src/main/java/fr/free/nrw/commons/nearby/mvp/NearbyListContract.java new file mode 100644 index 000000000..012ab5503 --- /dev/null +++ b/app/src/main/java/fr/free/nrw/commons/nearby/mvp/NearbyListContract.java @@ -0,0 +1,19 @@ +package fr.free.nrw.commons.nearby.mvp; + +/** + * This interface defines specific View and UserActions for list + * part of the nearby. On the other hand both extends methods + * from parent View and UserActions where general methods are + * defined (in Nearby Contract) + */ +public interface NearbyListContract { + + interface View extends NearbyContract.View { + + } + + interface UserActions extends NearbyContract.UserActions { + void openCommonsFilePage(); + void expandItem(); + } +} diff --git a/app/src/main/java/fr/free/nrw/commons/nearby/mvp/NearbyMapContract.java b/app/src/main/java/fr/free/nrw/commons/nearby/mvp/NearbyMapContract.java index faeec5d1f..0459f0a18 100644 --- a/app/src/main/java/fr/free/nrw/commons/nearby/mvp/NearbyMapContract.java +++ b/app/src/main/java/fr/free/nrw/commons/nearby/mvp/NearbyMapContract.java @@ -1,7 +1,14 @@ package fr.free.nrw.commons.nearby.mvp; +/** + * This interface defines specific View and UserActions for map + * part of the nearby. On the other hand both extends methods + * from parent View and UserActions where general methods are + * defined (in Nearby Contract) + */ public interface NearbyMapContract { - interface View extends NearbyContract.View { + + interface View extends NearbyContract.View{ void showSearchThisAreaButton(); void showInformationBottomSheet(); void showFABs();