Merge pull request #475 from veyndan/illegal-state

Don't have default values when obtaining item from spinner
This commit is contained in:
Josephine Lim 2017-04-06 01:29:03 +10:00 committed by GitHub
commit 24a3225280

View file

@ -152,7 +152,7 @@ public class SingleUploadFragment extends Fragment {
selectedText.setBackgroundColor(Color.TRANSPARENT); selectedText.setBackgroundColor(Color.TRANSPARENT);
} }
String license = Prefs.Licenses.CC_BY_SA_3; // default value String license;
if(getString(R.string.license_name_cc0).equals(licenseName)) { if(getString(R.string.license_name_cc0).equals(licenseName)) {
license = Prefs.Licenses.CC0; license = Prefs.Licenses.CC0;
} else if(getString(R.string.license_name_cc_by).equals(licenseName)) { } else if(getString(R.string.license_name_cc_by).equals(licenseName)) {
@ -163,6 +163,8 @@ public class SingleUploadFragment extends Fragment {
license = Prefs.Licenses.CC_BY_4; license = Prefs.Licenses.CC_BY_4;
} else if(getString(R.string.license_name_cc_by_sa_four).equals(licenseName)) { } else if(getString(R.string.license_name_cc_by_sa_four).equals(licenseName)) {
license = Prefs.Licenses.CC_BY_SA_4; license = Prefs.Licenses.CC_BY_SA_4;
} else {
throw new IllegalStateException("Unknown licenseName: " + licenseName);
} }
setLicenseSummary(license); setLicenseSummary(license);