mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 12:23:58 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix: Safe binding usage in MediaDetailFragment

Browse source
This commit is contained in:
Dev Jadiya 2025-06-18 18:30:03 +05:30
parent 6ee63e800c
commit 1fb9783039
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.kt
View file

@ -248,7 +248,9 @@ class MediaDetailFragment : CommonsDaggerSupportFragment(), CategoryEditHelper.C
private val scrollPosition: Unit private val scrollPosition: Unit
get() { get() {
initialListTop = binding.mediaDetailScrollView.scrollY bindingOrNull?.let {
initialListTop = it.mediaDetailScrollView.scrollY
}
} }
override fun onCreateView( override fun onCreateView(
@ -736,7 +738,7 @@ class MediaDetailFragment : CommonsDaggerSupportFragment(), CategoryEditHelper.C
object : BaseControllerListener<ImageInfo?>() { object : BaseControllerListener<ImageInfo?>() {
override fun onIntermediateImageSet(id: String, imageInfo: ImageInfo?) { override fun onIntermediateImageSet(id: String, imageInfo: ImageInfo?) {
imageInfoCache = imageInfo imageInfoCache = imageInfo
updateAspectRatio(binding.mediaDetailScrollView.width) bindingOrNull?.let { updateAspectRatio(it.mediaDetailScrollView.width) }
} }
override fun onFinalImageSet( override fun onFinalImageSet(
@ -745,7 +747,7 @@ class MediaDetailFragment : CommonsDaggerSupportFragment(), CategoryEditHelper.C
animatable: Animatable? animatable: Animatable?
) { ) {
imageInfoCache = imageInfo imageInfoCache = imageInfo
updateAspectRatio(binding.mediaDetailScrollView.width) bindingOrNull?.let { updateAspectRatio(it.mediaDetailScrollView.width) }
} }
} }