mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fix incorrect Fresco initialization. (#1895)

Browse source 
Fresco only needs to be initialized once, in the Application class.
Initializing it again can lead to undefined behavior, including crashes.
This commit is contained in:
Dmitry Brant 2018-09-10 11:05:51 -04:00 • committed by Vivek Maskara
parent 91f3f2e505
commit 1dd7cbb614
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/fr/free/nrw/commons/quiz/QuizActivity.java
View file

@ -13,7 +13,6 @@ import android.widget.ProgressBar;
import android.widget.RadioButton; import android.widget.RadioButton;
import android.widget.TextView; import android.widget.TextView;
import com.facebook.drawee.backends.pipeline.Fresco;
import com.facebook.drawee.drawable.ProgressBarDrawable; import com.facebook.drawee.drawable.ProgressBarDrawable;
import com.facebook.drawee.generic.GenericDraweeHierarchy; import com.facebook.drawee.generic.GenericDraweeHierarchy;
import com.facebook.drawee.generic.GenericDraweeHierarchyBuilder; import com.facebook.drawee.generic.GenericDraweeHierarchyBuilder;
@ -45,7 +44,6 @@ public class QuizActivity extends AppCompatActivity {
protected void onCreate(Bundle savedInstanceState) { protected void onCreate(Bundle savedInstanceState) {
super.onCreate(savedInstanceState); super.onCreate(savedInstanceState);
setContentView(R.layout.activity_quiz); setContentView(R.layout.activity_quiz);
Fresco.initialize(this);
quizController.initialize(this); quizController.initialize(this);
ButterKnife.bind(this); ButterKnife.bind(this);