From 1b86726364a3c17dbc3c936e980954c1616143bf Mon Sep 17 00:00:00 2001 From: Ashish Kumar Date: Thu, 28 Feb 2019 22:44:36 +0530 Subject: [PATCH] Bugfix #2476 (#2527) updated database version and added associated tests --- .../main/java/fr/free/nrw/commons/data/DBOpenHelper.java | 2 +- .../nrw/commons/contributions/ContributionDaoTest.kt | 9 +++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/fr/free/nrw/commons/data/DBOpenHelper.java b/app/src/main/java/fr/free/nrw/commons/data/DBOpenHelper.java index c9ecce289..449361474 100644 --- a/app/src/main/java/fr/free/nrw/commons/data/DBOpenHelper.java +++ b/app/src/main/java/fr/free/nrw/commons/data/DBOpenHelper.java @@ -14,7 +14,7 @@ import fr.free.nrw.commons.modifications.ModifierSequenceDao; public class DBOpenHelper extends SQLiteOpenHelper { private static final String DATABASE_NAME = "commons.db"; - private static final int DATABASE_VERSION = 9; + private static final int DATABASE_VERSION = 10; /** * Do not use directly - @Inject an instance where it's needed and let diff --git a/app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionDaoTest.kt b/app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionDaoTest.kt index 201b0225d..fd7e51fc1 100644 --- a/app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionDaoTest.kt +++ b/app/src/test/kotlin/fr/free/nrw/commons/contributions/ContributionDaoTest.kt @@ -126,6 +126,15 @@ class ContributionDaoTest { } } + @Test + fun migrateTableVersionFrom_v9_to_v10() { + Table.onUpdate(database, 8, 9) + // Table changed in version 9 + inOrder(database) { + verify(database).execSQL(Table.ADD_WIKI_DATA_ENTITY_ID_FIELD) + } + } + @Test fun saveNewContribution_nonNullFields() { whenever(client.insert(isA(), isA())).thenReturn(contentUri)