mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 12:53:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

NPE issue is not detected for now, can be solved on seperate PR

Browse source
This commit is contained in:
neslihanturan 2019-09-18 14:15:19 +03:00
parent e9ebd23b67
commit 1b3ce3840e
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
app/src/main/java/fr/free/nrw/commons/nearby/mvp/fragments/NearbyParentFragment.java
View file

@ -449,7 +449,8 @@ public class NearbyParentFragment extends CommonsDaggerSupportFragment
.subscribe(this::updateMapMarkers, .subscribe(this::updateMapMarkers,
throwable -> { throwable -> {
Timber.d(throwable); Timber.d(throwable);
showErrorMessage(getString(R.string.error_fetching_nearby_places)); // TODO: find out why NPE occurs here
// showErrorMessage(getString(R.string.error_fetching_nearby_places));
setProgressBarVisibility(false); setProgressBarVisibility(false);
nearbyParentFragmentPresenter.lockUnlockNearby(false); nearbyParentFragmentPresenter.lockUnlockNearby(false);
})); }));
@ -462,7 +463,8 @@ public class NearbyParentFragment extends CommonsDaggerSupportFragment
.subscribe(this::updateMapMarkersForCustomLocation, .subscribe(this::updateMapMarkersForCustomLocation,
throwable -> { throwable -> {
Timber.d(throwable); Timber.d(throwable);
showErrorMessage(getString(R.string.error_fetching_nearby_places)); // TODO: find out why NPE occurs here
// showErrorMessage(getString(R.string.error_fetching_nearby_places));
setProgressBarVisibility(false); setProgressBarVisibility(false);
nearbyParentFragmentPresenter.lockUnlockNearby(false); nearbyParentFragmentPresenter.lockUnlockNearby(false);
})); }));
@ -834,7 +836,6 @@ public class NearbyParentFragment extends CommonsDaggerSupportFragment
} }
private void showErrorMessage(String message) { private void showErrorMessage(String message) {
// TODO
ViewUtil.showLongToast(getActivity(), message); ViewUtil.showLongToast(getActivity(), message);
} }