mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Revert "Fix issue #1332 : Contribution Image auto/manual refresh if fetching fails" (#1609)

Browse source 
* Revert "Modify allow_gps_summary string (#1608)"

This reverts commit 3b6c94c8d6.

* Revert "Fix issue #1332 : Contribution Image auto/manual refresh if fetching fails"

This reverts commit 5aba7459bd.
This commit is contained in:
Josephine Lim 2018-06-11 16:53:23 +10:00 • committed by GitHub
parent 3b6c94c8d6
commit 1adb052705
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

1
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsActivity.java
View file

@ -144,6 +144,7 @@ public class ContributionsActivity
if(!BuildConfig.FLAVOR.equalsIgnoreCase("beta")){
setUploadCount();
}
}
@Override

10
app/src/main/java/fr/free/nrw/commons/contributions/ContributionsListFragment.java
View file

@ -7,7 +7,6 @@ import android.os.Build;
import android.os.Bundle;
import android.support.annotation.NonNull;
import android.support.v4.content.ContextCompat;
import android.support.v4.widget.SwipeRefreshLayout;
import android.support.v7.app.AlertDialog;
import android.view.LayoutInflater;
import android.view.Menu;
@ -48,8 +47,6 @@ public class ContributionsListFragment extends CommonsDaggerSupportFragment {
TextView waitingMessage;
@BindView(R.id.loadingContributionsProgressBar)
ProgressBar progressBar;
@BindView(R.id.swipeRefreshLayout)
SwipeRefreshLayout swipeRefreshLayout;
@Inject
@Named("prefs")
@ -67,13 +64,6 @@ public class ContributionsListFragment extends CommonsDaggerSupportFragment {
ButterKnife.bind(this, v);
contributionsList.setOnItemClickListener((AdapterView.OnItemClickListener) getActivity());
swipeRefreshLayout.setOnRefreshListener(new SwipeRefreshLayout.OnRefreshListener() {
@Override
public void onRefresh() {
((ContributionsListAdapter)contributionsList.getAdapter()).notifyDataSetChanged();
swipeRefreshLayout.setRefreshing(false);
}
});
if (savedInstanceState != null) {
Timber.d("Scrolling to %d", savedInstanceState.getInt("grid-position"));
contributionsList.setSelection(savedInstanceState.getInt("grid-position"));

7
app/src/main/res/layout/fragment_contributions.xml
View file

@ -24,11 +24,6 @@
android:id="@+id/loadingContributionsProgressBar"
/>
<android.support.v4.widget.SwipeRefreshLayout
android:id="@+id/swipeRefreshLayout"
android:layout_width="match_parent"
android:layout_height="match_parent">
<GridView
android:id="@+id/contributionsList"
android:layout_height="match_parent"
@ -40,5 +35,5 @@
android:fadingEdge="none"
android:fastScrollEnabled="true"
/>
</android.support.v4.widget.SwipeRefreshLayout>
</RelativeLayout>