mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Make new feedback to be added as a new section to the end of the page (#5753)

Browse source 
* feedback: add the feedback as a new section at end of the page

Addresses feedback on #5542. For auto-archiving of section
to work properly on our feedback page, the new sections need to
be created at the end of the page rather than at the top.

So, adjust the feedback addition logic to make it such that the
feedback is appended to the bottom of the page.

* Replace lambda with a method reference

* feedback: replace edit summary with something more relevant

The summary of the feedback page was unhelpful. Make it more helpful by
using a more helpful summary that at least mentions the version of the
app for which the feedback is posted.

* test: try to fix test case related to feedback change
This commit is contained in:
Kaartic Sivaraam 2024-06-19 01:10:30 +05:30 • committed by GitHub
parent 0e39d93721
commit 1808699e89
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
6 changed files with 100 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

3
app/src/test/kotlin/fr/free/nrw/commons/feedback/FeedbackContentCreatorUnitTests.kt
View file

@ -34,7 +34,8 @@ class FeedbackContentCreatorUnitTests {
fun testToString() {
feedback = Feedback("123", "apiLevel", "title", "androidVersion", "deviceModel", "mfg", "deviceName", "wifi")
creator = FeedbackContentCreator(context, feedback)
Assert.assertNotNull(creator.toString())
Assert.assertNotNull(creator.getSectionText())
Assert.assertNotNull(creator.getSectionTitle())
}
}

2
app/src/test/kotlin/fr/free/nrw/commons/navtab/MoreBottomSheetFragmentUnitTests.kt
View file

@ -119,7 +119,7 @@ class MoreBottomSheetFragmentUnitTests {
val feedback = mock(Feedback::class.java)
val observable: Observable<Boolean> = Observable.just(false)
val observable2: Observable<Boolean> = Observable.just(true)
doReturn(observable, observable2).`when`(pageEditClient).prependEdit(anyString(), anyString(), anyString())
doReturn(observable, observable2).`when`(pageEditClient).createNewSection(anyString(), anyString(), anyString(), anyString())
fragment.uploadFeedback(feedback)
}