From 1618640046a7749a9e8075f8e0f3e73430bf7343 Mon Sep 17 00:00:00 2001 From: Mikel Date: Wed, 2 Aug 2017 22:02:36 +0100 Subject: [PATCH] Make Codacy happy --- .../fr/free/nrw/commons/mwapi/UploadResult.java | 11 ----------- .../java/fr/free/nrw/commons/utils/UiUtils.java | 14 ++++++-------- 2 files changed, 6 insertions(+), 19 deletions(-) diff --git a/app/src/main/java/fr/free/nrw/commons/mwapi/UploadResult.java b/app/src/main/java/fr/free/nrw/commons/mwapi/UploadResult.java index 8a53e4b8b..34d050b2c 100644 --- a/app/src/main/java/fr/free/nrw/commons/mwapi/UploadResult.java +++ b/app/src/main/java/fr/free/nrw/commons/mwapi/UploadResult.java @@ -40,15 +40,4 @@ public class UploadResult { public String getResultStatus() { return resultStatus; } - - @Override - public String toString() { - return "UploadResult{" + - "errorCode='" + errorCode + '\'' + - ", resultStatus='" + resultStatus + '\'' + - ", dateUploaded=" + dateUploaded + - ", imageUrl='" + imageUrl + '\'' + - ", canonicalFilename='" + canonicalFilename + '\'' + - '}'; - } } diff --git a/app/src/main/java/fr/free/nrw/commons/utils/UiUtils.java b/app/src/main/java/fr/free/nrw/commons/utils/UiUtils.java index 3d3dcafff..361a766a2 100644 --- a/app/src/main/java/fr/free/nrw/commons/utils/UiUtils.java +++ b/app/src/main/java/fr/free/nrw/commons/utils/UiUtils.java @@ -30,25 +30,23 @@ public class UiUtils { /** * Converts dp unit to equivalent pixels. - * * @param dp density independent pixels - * @param context + * @param context Context to access display metrics * @return px equivalent to dp value */ - public static float convertDpToPixel(float dp, Context context){ + public static float convertDpToPixel(float dp, Context context) { DisplayMetrics metrics = context.getResources().getDisplayMetrics(); - return dp * ((float)metrics.densityDpi / DisplayMetrics.DENSITY_DEFAULT); + return dp * ((float) metrics.densityDpi / DisplayMetrics.DENSITY_DEFAULT); } /** * Converts device specific pixels to dp. - * * @param px pixels - * @param context + * @param context Context to access display metrics * @return dp equivalent to px value */ - public static float convertPixelsToDp(float px, Context context){ + public static float convertPixelsToDp(float px, Context context) { DisplayMetrics metrics = context.getResources().getDisplayMetrics(); - return px / ((float)metrics.densityDpi / DisplayMetrics.DENSITY_DEFAULT); + return px / ((float) metrics.densityDpi / DisplayMetrics.DENSITY_DEFAULT); } }