From 11e7b1cde7ce4e94c4e990f42ae36f8af5469276 Mon Sep 17 00:00:00 2001 From: Rohit Verma <101377978+rohit9625@users.noreply.github.com> Date: Thu, 18 Jan 2024 05:53:50 +0530 Subject: [PATCH] UploadMediaDetailInputFilter: added pattern to identify colon (#5451) Added hex code of colon for MediaDetailInputFilter and updated test for it. --- .../free/nrw/commons/upload/UploadMediaDetailInputFilter.java | 1 + .../free/nrw/commons/upload/UploadMediaDetailInputFilterTest.kt | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailInputFilter.java b/app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailInputFilter.java index 3c7fab96b..04498746d 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailInputFilter.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/UploadMediaDetailInputFilter.java @@ -20,6 +20,7 @@ public class UploadMediaDetailInputFilter implements InputFilter { Pattern.compile("[\\x{00A0}\\x{1680}\\x{180E}\\x{2000}-\\x{200B}\\x{2028}\\x{2029}\\x{202F}\\x{205F}]"), Pattern.compile("[\\x{202A}-\\x{202E}]"), Pattern.compile("\\p{Cc}"), + Pattern.compile("\\x{3A}"), // Added for colon(:) Pattern.compile("\\x{FEFF}"), Pattern.compile("\\x{00AD}"), Pattern.compile("[\\x{E000}-\\x{F8FF}\\x{FFF0}-\\x{FFFF}]"), diff --git a/app/src/test/kotlin/fr/free/nrw/commons/upload/UploadMediaDetailInputFilterTest.kt b/app/src/test/kotlin/fr/free/nrw/commons/upload/UploadMediaDetailInputFilterTest.kt index bb91f29fc..90c5e6042 100644 --- a/app/src/test/kotlin/fr/free/nrw/commons/upload/UploadMediaDetailInputFilterTest.kt +++ b/app/src/test/kotlin/fr/free/nrw/commons/upload/UploadMediaDetailInputFilterTest.kt @@ -61,7 +61,7 @@ class UploadMediaDetailInputFilterTest { builder.filters = arrayOf(UploadMediaDetailInputFilter()) //Sample of control characters - val tests = intArrayOf(0x00, 0x08, 0x10, 0x18, 0x1F, 0x7F) + val tests = intArrayOf(0x00, 0x08, 0x10, 0x18, 0x1F, 0x7F, 0x3A) for (test: Int in tests) { builder.insert(0, String(Character.toChars(test))) Assert.assertEquals(builder.toString(), "")