mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-27 12:53:55 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Check that fragment is added to activity to prevent crash

Browse source
This commit is contained in:
misaochan 2018-01-25 03:35:12 +10:00 • committed by maskara
parent 6cdf153bc1
commit 1167837b9f
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
app/src/main/java/fr/free/nrw/commons/contributions/ContributionController.java
View file

@ -70,6 +70,9 @@ public class ContributionController {
requestWritePermission(fragment.getContext(), takePictureIntent, lastGeneratedCaptureUri); requestWritePermission(fragment.getContext(), takePictureIntent, lastGeneratedCaptureUri);
takePictureIntent.putExtra(MediaStore.EXTRA_OUTPUT, lastGeneratedCaptureUri); takePictureIntent.putExtra(MediaStore.EXTRA_OUTPUT, lastGeneratedCaptureUri);
if (!fragment.isAdded()) {
return;
}
fragment.startActivityForResult(takePictureIntent, SELECT_FROM_CAMERA); fragment.startActivityForResult(takePictureIntent, SELECT_FROM_CAMERA);
} }
@ -79,6 +82,9 @@ public class ContributionController {
pickImageIntent.setType("image/*"); pickImageIntent.setType("image/*");
Timber.d("startGalleryPick() called with pickImageIntent"); Timber.d("startGalleryPick() called with pickImageIntent");
//TODO Add fix for IllegalStateException here //TODO Add fix for IllegalStateException here
if (!fragment.isAdded()) {
return;
}
fragment.startActivityForResult(pickImageIntent, SELECT_FROM_GALLERY); fragment.startActivityForResult(pickImageIntent, SELECT_FROM_GALLERY);
} }