mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

getColumnIndex(): added @SuppressLint("Range") as -1 is expected result for column name doesn't exist

Browse source
This commit is contained in:
Junwei Bai 2024-10-23 23:08:41 +11:00
parent d08842d60d
commit 0aa69fd6da
4 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/src/main/java/fr/free/nrw/commons/bookmarks/pictures/BookmarkPicturesDao.java
View file

@ -1,5 +1,6 @@
package fr.free.nrw.commons.bookmarks.pictures; package fr.free.nrw.commons.bookmarks.pictures;
import android.annotation.SuppressLint;
import android.content.ContentProviderClient; import android.content.ContentProviderClient;
import android.content.ContentValues; import android.content.ContentValues;
import android.database.Cursor; import android.database.Cursor;
@ -150,6 +151,7 @@ public class BookmarkPicturesDao {
return false; return false;
} }
@SuppressLint("Range")
@NonNull @NonNull
Bookmark fromCursor(Cursor cursor) { Bookmark fromCursor(Cursor cursor) {
String fileName = cursor.getString(cursor.getColumnIndex(Table.COLUMN_MEDIA_NAME)); String fileName = cursor.getString(cursor.getColumnIndex(Table.COLUMN_MEDIA_NAME));

2
app/src/main/java/fr/free/nrw/commons/category/CategoryDao.java
View file

@ -1,5 +1,6 @@
package fr.free.nrw.commons.category; package fr.free.nrw.commons.category;
import android.annotation.SuppressLint;
import android.content.ContentProviderClient; import android.content.ContentProviderClient;
import android.content.ContentValues; import android.content.ContentValues;
import android.database.Cursor; import android.database.Cursor;
@ -111,6 +112,7 @@ public class CategoryDao {
} }
@NonNull @NonNull
@SuppressLint("Range")
Category fromCursor(Cursor cursor) { Category fromCursor(Cursor cursor) {
// Hardcoding column positions! // Hardcoding column positions!
return new Category( return new Category(

2
app/src/main/java/fr/free/nrw/commons/explore/recentsearches/RecentSearchesDao.java
View file

@ -1,5 +1,6 @@
package fr.free.nrw.commons.explore.recentsearches; package fr.free.nrw.commons.explore.recentsearches;
import android.annotation.SuppressLint;
import android.content.ContentProviderClient; import android.content.ContentProviderClient;
import android.content.ContentValues; import android.content.ContentValues;
import android.database.Cursor; import android.database.Cursor;
@ -178,6 +179,7 @@ public class RecentSearchesDao {
* @return RecentSearch object * @return RecentSearch object
*/ */
@NonNull @NonNull
@SuppressLint("Range")
RecentSearch fromCursor(Cursor cursor) { RecentSearch fromCursor(Cursor cursor) {
// Hardcoding column positions! // Hardcoding column positions!
return new RecentSearch( return new RecentSearch(

2
app/src/main/java/fr/free/nrw/commons/recentlanguages/RecentLanguagesDao.java
View file

@ -1,5 +1,6 @@
package fr.free.nrw.commons.recentlanguages; package fr.free.nrw.commons.recentlanguages;
import android.annotation.SuppressLint;
import android.content.ContentProviderClient; import android.content.ContentProviderClient;
import android.content.ContentValues; import android.content.ContentValues;
import android.database.Cursor; import android.database.Cursor;
@ -117,6 +118,7 @@ public class RecentLanguagesDao {
* @return Language object * @return Language object
*/ */
@NonNull @NonNull
@SuppressLint("Range")
Language fromCursor(final Cursor cursor) { Language fromCursor(final Cursor cursor) {
// Hardcoding column positions! // Hardcoding column positions!
final String languageName = cursor.getString(cursor.getColumnIndex(Table.COLUMN_NAME)); final String languageName = cursor.getString(cursor.getColumnIndex(Table.COLUMN_NAME));