Make AuthenticatedActivity abstract (per lint)

This commit is contained in:
Yusuke Matsubara 2016-07-09 12:47:50 +09:00
parent 943fcbc7ea
commit 08bc52e457
4 changed files with 3 additions and 11 deletions

View file

@ -11,7 +11,7 @@ import android.support.v7.app.AppCompatActivity;
import fr.free.nrw.commons.CommonsApplication;
import fr.free.nrw.commons.Utils;
public class AuthenticatedActivity extends AppCompatActivity {
public abstract class AuthenticatedActivity extends AppCompatActivity {
String accountType;
@ -143,10 +143,6 @@ public class AuthenticatedActivity extends AppCompatActivity {
outState.putString("authCookie", authCookie);
}
protected void onAuthCookieAcquired(String authCookie) {
}
protected void onAuthFailure() {
}
protected abstract void onAuthCookieAcquired(String authCookie);
protected abstract void onAuthFailure();
}

View file

@ -188,7 +188,6 @@ public class ContributionsActivity
@Override
protected void onAuthFailure() {
super.onAuthFailure();
finish(); // If authentication failed, we just exit
}

View file

@ -236,7 +236,6 @@ public class MultipleShareActivity
@Override
protected void onAuthFailure() {
super.onAuthFailure();
Toast failureToast = Toast.makeText(this, R.string.authentication_failed, Toast.LENGTH_LONG);
failureToast.show();
finish();

View file

@ -158,7 +158,6 @@ public class ShareActivity
@Override
protected void onAuthCookieAcquired(String authCookie) {
super.onAuthCookieAcquired(authCookie);
app.getApi().setAuthCookie(authCookie);
@ -176,7 +175,6 @@ public class ShareActivity
@Override
protected void onAuthFailure() {
super.onAuthFailure();
Toast failureToast = Toast.makeText(this, R.string.authentication_failed, Toast.LENGTH_LONG);
failureToast.show();
finish();