From 9543c03cab66659781d7d87325bcede17278312c Mon Sep 17 00:00:00 2001 From: misaochan Date: Tue, 12 Jul 2016 18:06:50 +1200 Subject: [PATCH 1/2] Add exception logging to UploadController --- .../java/fr/free/nrw/commons/upload/UploadController.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/fr/free/nrw/commons/upload/UploadController.java b/app/src/main/java/fr/free/nrw/commons/upload/UploadController.java index ba896da37..398a74dc3 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/UploadController.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/UploadController.java @@ -13,6 +13,7 @@ import android.os.IBinder; import android.preference.PreferenceManager; import android.provider.MediaStore; import android.text.TextUtils; +import android.util.Log; import android.webkit.MimeTypeMap; import java.io.IOException; @@ -119,7 +120,9 @@ public class UploadController { contribution.setDataLength(length); } } catch(IOException e) { - throw new RuntimeException(e); + Log.e("UploadController", "IO Exception: ", e); + } catch(NullPointerException e) { + Log.e("UploadController", "Null Pointer Exception: ", e); } String mimeType = (String)contribution.getTag("mimeType"); From b30bee5b0f1e6c77675771c6b6cf06bb51edb484 Mon Sep 17 00:00:00 2001 From: misaochan Date: Tue, 12 Jul 2016 18:10:08 +1200 Subject: [PATCH 2/2] Null check for cursor close --- .../main/java/fr/free/nrw/commons/upload/UploadController.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/src/main/java/fr/free/nrw/commons/upload/UploadController.java b/app/src/main/java/fr/free/nrw/commons/upload/UploadController.java index 398a74dc3..aaedcc8df 100644 --- a/app/src/main/java/fr/free/nrw/commons/upload/UploadController.java +++ b/app/src/main/java/fr/free/nrw/commons/upload/UploadController.java @@ -145,10 +145,10 @@ public class UploadController { dateCreated = new Date(); } contribution.setDateCreated(dateCreated); + cursor.close(); } else { contribution.setDateCreated(new Date()); } - cursor.close(); } return contribution;