mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-31 06:43:56 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixed #2825 where user was able to add one lang twice (#2834)

Browse source 
* Fixed #2825 where user was able to add one lang twice

* Added Comments
This commit is contained in:
Madhur Gupta 2019-04-02 16:47:01 +05:30 • committed by neslihanturan
parent 835b7979ff
commit 0289ae17c5
1 changed files with 15 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

16
app/src/main/java/fr/free/nrw/commons/upload/DescriptionsAdapter.java
View file

@ -229,7 +229,21 @@ class DescriptionsAdapter extends RecyclerView.Adapter<DescriptionsAdapter.ViewH
int defaultLocaleIndex = languagesAdapter.getIndexOfUserDefaultLocale(context);
spinnerDescriptionLanguages.setSelection(defaultLocaleIndex);
} else {
spinnerDescriptionLanguages.setSelection(0);
// availableLangIndex gives the index of first non-selected language
int availableLangIndex = -1;
// loops over the languagesAdapter and finds the index of first non-selected language
for (int i = 0; i < languagesAdapter.getCount(); i++) {
if (!selectedLanguages.containsKey(languagesAdapter.getLanguageCode(i))) {
availableLangIndex = i;
break;
}
}
if (availableLangIndex >= 0) {
// sets the spinner value to the index of first non-selected language
spinnerDescriptionLanguages.setSelection(availableLangIndex);
selectedLanguages.put(spinnerDescriptionLanguages, languagesAdapter.getLanguageCode(position));
}
}
} else {
spinnerDescriptionLanguages.setSelection(description.getSelectedLanguageIndex());