Fix crash(es) upon upload failure. (#2699)

* Fix crash(es) upon upload failure.

* Further improve Rx structure.
This commit is contained in:
Dmitry Brant 2019-03-21 12:09:36 -04:00 committed by neslihanturan
parent a32ba452ec
commit 013e1a5430
3 changed files with 71 additions and 75 deletions

View file

@ -944,7 +944,7 @@ public class ApacheHttpClientMediaWikiApi implements MediaWikiApi {
long dataLength,
Uri fileUri,
Uri contentProviderUri,
ProgressListener progressListener) throws IOException {
ProgressListener progressListener) {
return Single.fromCallable(() -> {
CustomApiResult result = api.uploadToStash(filename, file, dataLength, getEditToken(), progressListener::onProgress);

View file

@ -9,7 +9,6 @@ import java.io.InputStream;
import java.util.List;
import fr.free.nrw.commons.Media;
import fr.free.nrw.commons.campaigns.CampaignResponseDTO;
import fr.free.nrw.commons.notification.Notification;
import io.reactivex.Observable;
import io.reactivex.Single;
@ -53,7 +52,7 @@ public interface MediaWikiApi {
@NonNull
Single<UploadStash> uploadFile(String filename, InputStream file,
long dataLength, Uri fileUri, Uri contentProviderUri,
final ProgressListener progressListener) throws IOException;
final ProgressListener progressListener);
@NonNull
Single<UploadResult> uploadFileFinalize(String filename, String filekey,