mnalis/apps-android-commons
1
0
Fork 0
mirror of https://github.com/commons-app/apps-android-commons.git synced 2025-10-26 20:33:53 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Fixes #5187: Fix App crashes when you click on Author Name (#5199)

Browse source 
* Add conditional on function onAuthorViewClicked for when there's not logged-in user

* Change media.getAuthor() for media.getUser()

* Change hardcoded URL for one given by the BuildConfig object
This commit is contained in:
José Arias Canto 2023-04-13 04:59:50 -06:00 • committed by GitHub
parent 9fb13395f6
commit 013809f46a
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
app/src/main/java/fr/free/nrw/commons/media/MediaDetailFragment.java
View file

@ -57,6 +57,7 @@ import com.facebook.imagepipeline.image.ImageInfo;
import com.facebook.imagepipeline.request.ImageRequest; import com.facebook.imagepipeline.request.ImageRequest;
import com.mapbox.mapboxsdk.camera.CameraPosition; import com.mapbox.mapboxsdk.camera.CameraPosition;
import com.mapbox.mapboxsdk.geometry.LatLng; import com.mapbox.mapboxsdk.geometry.LatLng;
import fr.free.nrw.commons.BuildConfig;
import fr.free.nrw.commons.LocationPicker.LocationPicker; import fr.free.nrw.commons.LocationPicker.LocationPicker;
import fr.free.nrw.commons.Media; import fr.free.nrw.commons.Media;
import fr.free.nrw.commons.MediaDataExtractor; import fr.free.nrw.commons.MediaDataExtractor;
@ -1232,6 +1233,12 @@ public class MediaDetailFragment extends CommonsDaggerSupportFragment implements
if (media == null || media.getUser() == null) { if (media == null || media.getUser() == null) {
return; return;
} }
if (sessionManager.getUserName() == null) {
String userProfileLink = BuildConfig.COMMONS_URL + "/wiki/User:" + media.getUser();
Intent browserIntent = new Intent(Intent.ACTION_VIEW, Uri.parse(userProfileLink));
startActivity(browserIntent);
return;
}
ProfileActivity.startYourself(getActivity(), media.getUser(), !Objects ProfileActivity.startYourself(getActivity(), media.getUser(), !Objects
.equals(sessionManager.getUserName(), media.getUser())); .equals(sessionManager.getUserName(), media.getUser()));
} }